doc: correct crypto encoding information (v4.x)#7799
Closed
addaleax wants to merge 2 commits intonodejs:v4.x-stagingfrom
Closed
doc: correct crypto encoding information (v4.x)#7799addaleax wants to merge 2 commits intonodejs:v4.x-stagingfrom
addaleax wants to merge 2 commits intonodejs:v4.x-stagingfrom
Conversation
The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of `binary`. Ref: nodejs#5500 Fixes: nodejs#7712
addaleax
added
crypto
addaleax
changed the title
Contributor
|
LGTM |
Member
|
LGTM. Perhaps the documentation could be explicit about the fact that the default encoding changed in v6? Aside: 'enforced' is a bit of an odd choice of words. |
Member
Author
|
I’ve updated with “implied” substituted where “enforced” is currently being used. And +1 to being explicit about the change in v6, but that should probably go into a different PR against master. |
Contributor
|
@addaleax is this important enough to be rolled into v4.5.0 or could it wait for the next patch release? |
Member
Author
|
@thealphanerd uff… doesn’t really matter? It can wait, but it’s a only a correction in the docs. |
Member
|
LGTM |
Member
|
Landed in d771d5e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
The default encoding for crypto methods was changed in v6.0.0, with v4.x keeping a default of
binary.Ref: #5500
Fixes: #7712